Fix array API inspection behavior with device keyword#1979
Merged
ndgrigorian merged 4 commits intomasterfrom Jan 24, 2025
Merged
Fix array API inspection behavior with device keyword#1979ndgrigorian merged 4 commits intomasterfrom
device keyword#1979ndgrigorian merged 4 commits intomasterfrom
Conversation
* Fixes a bug where `"complex128"` was present in the list of dtypes on devices without fp64 support * Fixes functionality of device keyword for SyclQueue and strings * Improves error message when device keyword cannot be used to construct a SyclDevice instance * Tweaks docstring for device keywords in inspection utilities
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_493 ran successfully. |
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_494 ran successfully. |
Collaborator
Collaborator
Author
|
@antonwolfy |
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_496 ran successfully. |
antonwolfy
approved these changes
Jan 24, 2025
Collaborator
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
I checked with dpnp changes added in dpnp-2275 and it works as expected now.
Thank you @ndgrigorian for a quick fix. LGTM!
oleksandr-pavlyk
approved these changes
Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes changing the handling of the
devicekeyword in the array API inspection utilities to:Also fixes the
dtypesutility returningcomplex128in its output when the provided device does not support double precision types.Resolves #1978 , resolves #1977